makechrootpkg: Have functions be more function-y.

Rather than them simply being named blocks of code with braces around
them.

That is: have them take things via arguments rather than global
variables.

Specific notes:

 - download_sources:

   Observation: if $SUDO_USER is set, then src_owner=$SUDO_USER.

   So (for clarity), rather than checking if $SUDO_USER is set, check
   if $src_owner is different than $USER.

   This reduces how much we have to worry about global state.

 - install_packages:

    1. Receive the list of packages as arguments, rather than a global
       variable.
    2. Make the caller responsible for looking at PKGBUILD.  From the
       name and arguments, one would never expect it to look at PKGBUILD.

 - create_chroot->sync_chroot:

   I pulled the `if [[ ! -d $copydir ]] || $clean_first;` check out; it is
   now the caller's responsibility to use that check when deciding if to
   call sync_chroot.

0 files changed, 0 insertions, 0 deletions