Send patches - preferably formatted by git format-patch - to patches at archlinux32 dot org.
summaryrefslogtreecommitdiff
path: root/lib/common.sh
diff options
context:
space:
mode:
authorLuke Shumaker <lukeshu@parabola.nu>2017-02-15 15:36:21 -0500
committerLuke Shumaker <lukeshu@parabola.nu>2017-04-05 14:42:43 -0400
commit8ff392c0524ac24a48c3dfc8a2c6a8363f28d7f2 (patch)
tree6196df75647e127080c33f2141ce137e1cd14f5b /lib/common.sh
parent7eefbd294efa5b226fc60953ee2e92f1641fdeea (diff)
makechrootpkg: Have functions be more function-y.
Rather than them simply being named blocks of code with braces around them. That is: have them take things via arguments rather than global variables. Specific notes: - create_chroot->sync_chroot: I pulled out locking the destination chroot; getting that lock is now the caller's responsibility. It still handles locking the source chroot though. I pulled the `if [[ ! -d $copydir ]] || $clean_first;` check out; it is now the caller's responsibility to use that check when deciding if to call sync_chroot. However, when pulling that check out, I left it as `if true;`, to keep an indentation level. This patch has had to be rebased/merged many times, and changing the indentation is a sure way to make that go less smoothly; I'm not going to re-indent this block until I see the check removed in the git.archlinux.org/devtools.git repository. - install_packages: 1. Receive the list of packages as arguments, rather than a global variable. 2. Make the caller responsible for looking at PKGBUILD. From the name and arguments, one would never expect it to look at PKGBUILD.
Diffstat (limited to 'lib/common.sh')
0 files changed, 0 insertions, 0 deletions