Send patches - preferably formatted by git format-patch - to patches at archlinux32 dot org.
summaryrefslogtreecommitdiff
path: root/commitpkg.in
diff options
context:
space:
mode:
authorEli Schwartz <eschwartz@archlinux.org>2017-09-03 03:53:40 -0400
committerLuke Shumaker <lukeshu@parabola.nu>2018-01-03 14:55:21 -0500
commit8e8a5ebb72154fdc0450c74256a02fbc5da8de42 (patch)
treef04766c8b5359f6a1d9f962ef6cf5a1fabc375f7 /commitpkg.in
parent73c1581fef3a5410b1edc9600e45edc15991784f (diff)
makechrootpkg: Fix anti-pattern when checking for enabled features
Don't use error-prone logic e.g. foo=true; if $foo ... This completely fails to act as expected when the variable is unset because of unrelated bugs. While this merely causes the default behavior to be "false" rather than "true" in such cases, it is better to fail to enable explicitly requested behavior (which will be noticed by the user) than to simply upgrade to this behavior for free (which may not seem to have any obvious cause). Signed-off-by: Eli Schwartz <eschwartz@archlinux.org> Reviewed-by: Luke Shumaker <lukeshu@parabola.nu>
Diffstat (limited to 'commitpkg.in')
0 files changed, 0 insertions, 0 deletions