Send patches - preferably formatted by git format-patch - to patches at archlinux32 dot org.
summaryrefslogtreecommitdiff
path: root/checkpkg.in
diff options
context:
space:
mode:
authorLuke Shumaker <lukeshu@parabola.nu>2017-02-15 15:36:21 -0500
committerLuke Shumaker <lukeshu@parabola.nu>2017-02-19 14:21:29 -0500
commit9b93f4c12d3de7c36f4342e4e764b91ed91231f4 (patch)
treeae7443b9528d0a174fb5a63a07b6db9b31463b8d /checkpkg.in
parent8c805dd74b5d29e9994b7fbf7f849a0b6acd29b8 (diff)
makechrootpkg: Have functions be more function-y.
Rather than them simply being named blocks of code with braces around them. That is: have them take things via arguments rather than global variables. Specific notes: - download_sources: Observation: if $SUDO_USER is set, then src_owner=$SUDO_USER. So (for clarity), rather than checking if $SUDO_USER is set, check if $src_owner is different than $USER. This reduces how much we have to worry about global state. - install_packages: 1. Receive the list of packages as arguments, rather than a global variable. 2. Make the caller responsible for looking at PKGBUILD. From the name and arguments, one would never expect it to look at PKGBUILD. - create_chroot->sync_chroot: I pulled the `if [[ ! -d $copydir ]] || $clean_first;` check out; it is now the caller's responsibility to use that check when deciding if to call sync_chroot.
Diffstat (limited to 'checkpkg.in')
0 files changed, 0 insertions, 0 deletions