Send patches - preferably formatted by git format-patch - to patches at archlinux32 dot org.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJan Alexander Steffens (heftig) <jan.steffens@gmail.com>2013-05-09 02:31:35 +0200
committerJan Alexander Steffens (heftig) <jan.steffens@gmail.com>2013-05-11 12:26:21 +0200
commitfc71be3479d4330dfac8641fe0a6d0517964e4be (patch)
tree5b4e07568f89bc40442347bb9b94522de81a2e8e
parent38692e8d742a99e78b6f157c65dcf06dbf0c4c02 (diff)
makechrootpkg: Update comments to point out the bad hacks
-rw-r--r--makechrootpkg.in7
1 files changed, 4 insertions, 3 deletions
diff --git a/makechrootpkg.in b/makechrootpkg.in
index c7baf4d..dbe705e 100644
--- a/makechrootpkg.in
+++ b/makechrootpkg.in
@@ -208,7 +208,8 @@ prepare_chroot() {
echo 'LOGDEST="/logdest"' >> "$copydir/etc/makepkg.conf"
fi
- # These two get bind-mounted
+ # These two get bind-mounted read-only
+ # XXX: makepkg dislikes having these dirs read-only, so separate them
mkdir -p "$copydir/startdir" "$copydir/startdir_host"
mkdir -p "$copydir/srcdest" "$copydir/srcdest_host"
if ! grep -q 'SRCDEST="/srcdest"' "$copydir/etc/makepkg.conf"; then
@@ -271,13 +272,13 @@ _chrootbuild() {
export HOME=/build
shopt -s nullglob
- # Workaround makepkg disliking read-only dirs
+ # XXX: Workaround makepkg disliking read-only dirs
ln -sft /srcdest /srcdest_host/*
ln -sft /startdir /startdir_host/*
cd /startdir
- # Keep PKGBUILD writable for pkgver()
+ # XXX: Keep PKGBUILD writable for pkgver()
rm PKGBUILD*
cp /startdir_host/PKGBUILD* .
chown nobody PKGBUILD*