Send patches - preferably formatted by git format-patch - to patches at archlinux32 dot org.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLuke Shumaker <lukeshu@parabola.nu>2017-05-05 18:41:05 -0400
committerErich Eckner <git@eckner.net>2017-07-14 06:54:28 +0200
commit7494a6d3e615ea601c2a5dc5b45ceed18ceda2b6 (patch)
tree714280081e6b1513bf066aa0a8356eda7c5b5b9f
parent5a916f3b9bea81d6461ad5543a1c77bc81da72ff (diff)
makechrootpkg: Add a comment warning about a bug in "sudo -i"
The bug isn't currently triggered, but I accidentally did trigger when I was trying to modify the command a bit. I figure a "caution" sign would be helpful to any future developers.
-rw-r--r--makechrootpkg.in4
1 files changed, 4 insertions, 0 deletions
diff --git a/makechrootpkg.in b/makechrootpkg.in
index 3b38ad2..4b6e129 100644
--- a/makechrootpkg.in
+++ b/makechrootpkg.in
@@ -242,6 +242,10 @@ EOF
# so no global variables
_chrootbuild() {
. /etc/profile
+ # Beware, there are some stupid arbitrary rules on how you can
+ # use "$" in arguments to commands with "sudo -i". ${foo} or
+ # ${1} is OK, but $foo or $1 isn't.
+ # https://bugzilla.sudo.ws/show_bug.cgi?id=765
sudo -iu builduser bash -c 'cd /startdir; makepkg "$@"' -bash "$@"
}