Send patches - preferably formatted by git format-patch - to patches at archlinux32 dot org.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLuke Shumaker <lukeshu@parabola.nu>2017-05-05 18:41:05 -0400
committerJan Alexander Steffens (heftig) <jan.steffens@gmail.com>2017-07-05 18:21:55 +0200
commit56cace32b29e427e2f33754cf7f50bf691b619ce (patch)
tree7541d8794374de54430c6eda2db1e18cc8d004cb
parent2fdd1654b5dbfa508b15e258b51af1a000402459 (diff)
makechrootpkg: Add a comment warning about a bug in "sudo -i"
The bug isn't currently triggered, but I accidentally did trigger when I was trying to modify the command a bit. I figure a "caution" sign would be helpful to any future developers.
-rw-r--r--makechrootpkg.in4
1 files changed, 4 insertions, 0 deletions
diff --git a/makechrootpkg.in b/makechrootpkg.in
index d922fa0..2a19dbb 100644
--- a/makechrootpkg.in
+++ b/makechrootpkg.in
@@ -241,6 +241,10 @@ EOF
# so no global variables
_chrootbuild() {
. /etc/profile
+ # Beware, there are some stupid arbitrary rules on how you can
+ # use "$" in arguments to commands with "sudo -i". ${foo} or
+ # ${1} is OK, but $foo or $1 isn't.
+ # https://bugzilla.sudo.ws/show_bug.cgi?id=765
sudo -iu builduser bash -c 'cd /startdir; makepkg "$@"' -bash "$@"
}