Send patches - preferably formatted by git format-patch - to patches at archlinux32 dot org.
summaryrefslogtreecommitdiff
path: root/bin/strict-bashism-check
blob: f1a8de6e0512ec84d2b4391e936915c6041c3169 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
#!/bin/sh

if git rev-parse --verify HEAD >/dev/null 2>&1
then
  against=HEAD
else
  # Initial commit: diff against an empty tree object
  against=4b825dc642cb6eb9a060e54bf8d69288fbee4904
fi

check_files=$(
  git diff --cached --name-status "${against}" \
  | cut -f2
)

# If you want to allow non-ASCII filenames set this variable to true.
allownonascii=$(git config --bool hooks.allownonascii)

# Redirect output to stderr.
exec 1>&2

# Cross platform projects tend to avoid non-ASCII filenames; prevent
# them from being added to the repository. We exploit the fact that the
# printable range starts at the space character and ends with tilde.
if [ "$allownonascii" != "true" ] &&
  # Note that the use of brackets around a tr range is ok here, (it's
  # even required, for portability to Solaris 10's /usr/bin/tr), since
  # the square bracket bytes happen to fall in the designated range.
  test "$(git diff --cached --name-only --diff-filter=A -z $against |
    LC_ALL=C tr -d '[ -~]\0' | wc -c)" != 0
then
  cat <<\EOF
Error: Attempt to add a non-ASCII file name.

This can cause problems if you want to work with people on other platforms.

To be portable it is advisable to rename the file.

If you know what you are doing you can disable this check using:

  git config hooks.allownonascii true
EOF
  exit 1
fi

# If there are whitespace errors, print the offending file names and fail.
git diff-index --check --cached $against -- || exit $?

tree=$(git write-tree)

tmp_dir=$(mktemp -d 'tmp.strict-bashism-check.XXXXXXXXXX' --tmpdir)
trap 'rm -rf --one-file-system "${tmp_dir}"' EXIT

git archive "${tree}" | \
  tar -C "${tmp_dir}" -x

if ! cd "${tmp_dir}"; then
  echo 'Cannot cd.'
  exit 1
fi

errors=$(
  find bin lib -type f -not -executable -not -name '.gitignore'
)

if [ -n "${errors}" ]; then
  >&2 echo 'Non-executable files found in bin/ or lib/:'
  >&2 echo "${errors}"
  exit 1
fi

errors=$(
  grep -r '\(\s\|^\)mysql buildmaster\($\|\s\)' bin lib conf
)

if [ -n "${errors}" ]; then
  >&2 echo 'Style error: call "mysql_run_query" instead of "mysql buildmaster":'
  >&2 echo "${errors}"
  exit 1
fi

errors=$(
# shellcheck disable=SC2016
  find bin conf lib -type f -executable -exec grep -H '^\s*\S\+="\$(' {} \;
)

if [ -n "${errors}" ]; then
  >&2 echo 'Unnecessary quotes found:'
  >&2 echo "${errors}"
  exit 1
fi

if command -v shellcheck >/dev/null 2>&1; then
  errors=$(
    find bin conf lib \
      -type f \
      -executable \
      -not -name '.*' \
    | grep -xF "${check_files}" \
    | while read -r file; do
      (
        cd "${file%/*}" || exit $?
        shellcheck -x "${file##*/}" 2>&1
      )
    done
  )

  if [ -n "${errors}" ]; then
    >&2 echo 'shellcheck complains about the following:'
    >&2 echo "${errors}"
    exit 1
  fi
fi