Send patches - preferably formatted by git format-patch - to patches at archlinux32 dot org.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDave Reisner <dreisner@archlinux.org>2018-09-13 20:35:28 -0400
committerErick Cafferata <erick@cafferata.me>2018-11-03 13:30:02 -0500
commit394cd33f76f40ba9e8e231180e1bb397cd91c131 (patch)
tree67a8d1b75b1e005dcdb065f6b46be8145a57e9d1
parenta7da0d9a5be1f07a8f1ea1090ff4fea0de3bc6ed (diff)
Fix some shellcheck warnings
-rw-r--r--asp32.in14
-rw-r--r--util.inc.sh1
2 files changed, 8 insertions, 7 deletions
diff --git a/asp32.in b/asp32.in
index c5f5417..b5471d8 100644
--- a/asp32.in
+++ b/asp32.in
@@ -5,8 +5,8 @@ ARCH_GIT_REPOS=(packages64 community64 packages32)
OPT_ARCH=$(uname -m)
OPT_FORCE=0
-: ${ASPROOT:=${XDG_CACHE_HOME:-$HOME/.cache}/asp32}
-: ${ASPCACHE:=$ASPROOT/cache}
+: "${ASPROOT:=${XDG_CACHE_HOME:-$HOME/.cache}/asp32}"
+: "${ASPCACHE:=$ASPROOT/cache}"
m4_include(util.inc.sh)
m4_include(remote.inc.sh)
@@ -53,12 +53,12 @@ __require_argc() {
local min max argc=$2
case $1 in
- *-*)
- IFS=- read -r min max <<<"$1"
- ;;
*-)
min=${1%-}
;;
+ *-*)
+ IFS=- read -r min max <<<"$1"
+ ;;
*)
min=$1 max=$1
;;
@@ -207,7 +207,7 @@ untrack() {
disk_usage() {
local usage
- read usage _ < <(du -sh "$ASPROOT")
+ read -r usage _ < <(du -sh "$ASPROOT")
log_info 'Using %s on disk.' "$usage"
}
@@ -319,7 +319,7 @@ dispatch_action() {
# exact match
if declare -F "action__$1" &>/dev/null; then
- "action__$@"
+ "action__$1" "${@:2}"
return
fi
diff --git a/util.inc.sh b/util.inc.sh
index 7529eca..3aae736 100644
--- a/util.inc.sh
+++ b/util.inc.sh
@@ -1,4 +1,5 @@
log_meta() {
+ # shellcheck disable=SC2059
printf "$1 $2\\n" "${@:3}"
}