From d060e31be3586ce27382f80eaed7a9edf2c86aeb Mon Sep 17 00:00:00 2001 From: Nagy Gabor Date: Mon, 10 Mar 2008 15:38:08 +0100 Subject: Remove trans->targets Its implementation was quite broken: * add_loadtarget() might have silently filtered out some targets when replacing an older version. * This was used in sync.c to determine whether a target is implicit or not, which is incorrect behavior. Before this patch we silently removed user confirmed replacements; now we always warn on a replacement. * remove001.py behavior was quite odd in adding same target 5 times to the target list, we can change this behavior to be a failure. Signed-off-by: Nagy Gabor [Xav: changed remove001 pactest accordingly] Signed-off-by: Chantry Xavier [Dan: rewrote commit message] Signed-off-by: Dan McGee --- pactest/tests/remove001.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'pactest') diff --git a/pactest/tests/remove001.py b/pactest/tests/remove001.py index 809bfdb7..d20dd079 100644 --- a/pactest/tests/remove001.py +++ b/pactest/tests/remove001.py @@ -1,4 +1,3 @@ -# If someone else can come up with a better name, please do so self.description = "Remove a package listed 5 times" p = pmpkg("foo") @@ -6,5 +5,5 @@ self.args = "-R " + "foo "*5 -self.addrule("PACMAN_RETCODE=0") -self.addrule("!PKG_EXISTS=foo") +self.addrule("PACMAN_RETCODE=1") +self.addrule("PKG_EXISTS=foo") -- cgit v1.2.3-54-g00ecf