Use dynamic string allocation in package structures

This also affects all structures with static strings, such as depmiss,
conflict, etc. This should help a lot with memory usage, and hopefully make
things a bit more "idiot proof".

Currently our pactest pass/fail rate is identical before and after this
patch. This is not to say it is a perfect patch- I have yet to pull valgrind
out. However, this should be quite safe to use in all situations from here
on out, and we can start plugging the memleaks.

Original-work-by: Aaron Griffin <aaronmgriffin@gmail.com>
Signed-off-by: Dan McGee <dan@archlinux.org>

1 files changed, 4 insertions, 0 deletions

diff --git a/src/pacman/util.c b/src/pacman/util.c
index 1806ee52..a3ac66a7 100644
--- a/src/pacman/util.c
+++ b/src/pacman/util.c
@@ -194,6 +194,10 @@ void indentprint(const char *str, int indent)
 	const char *p = str;
 	int cidx = indent;
 
+	if(!p) {
+		return;
+	}
+
 	while(*p) {
 		if(*p == ' ') {
 			const char *next = NULL;