Send patches - preferably formatted by git format-patch - to patches at archlinux32 dot org.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDan McGee <dan@archlinux.org>2011-10-17 09:38:35 -0500
committerDan McGee <dan@archlinux.org>2011-10-17 09:38:35 -0500
commitbac670ddc9a9dcad2f0665f9f77d04b6736c6db4 (patch)
treee0be1900af04b8b3a346aed23c72b831b8f6f9fb
parent842c4422eda231892d4bce75d8e315eb652533b6 (diff)
Show an error message on failed remote key lookup
The absolutely terrible part about this is the failure on GPGME's part to distinguish between "key not found" and "keyserver timeout". Instead, it returns the same silly GPG_ERR_EOF in both cases (why isn't GPG_ERR_TIMEOUT being used?), leaving us helpless to tell them apart. Spit out a generic enough error message that covers both cases; unfortunately we can't provide much guidance to the user because we aren't sure what actually happened. Signed-off-by: Dan McGee <dan@archlinux.org>
-rw-r--r--lib/libalpm/signing.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/libalpm/signing.c b/lib/libalpm/signing.c
index bdaa83ad..92f34b56 100644
--- a/lib/libalpm/signing.c
+++ b/lib/libalpm/signing.c
@@ -797,8 +797,8 @@ int _alpm_process_siglist(alpm_handle_t *handle, const char *identifier,
fetch_key.fingerprint, fetch_key.uid);
}
} else {
- _alpm_log(handle, ALPM_LOG_DEBUG,
- "key could not be looked up remotely\n");
+ _alpm_log(handle, ALPM_LOG_ERROR,
+ _("key \"%s\" could not be looked up remotely\n"), name);
}
gpgme_key_unref(fetch_key.data);
}