From 043262b5f71e3030ad5553597b0e9696f6ff56b2 Mon Sep 17 00:00:00 2001 From: David Runge Date: Sat, 11 Jul 2020 18:13:20 +0200 Subject: Adding linting for initcpio scripts archiso/initcpio/install/*: Setting bash shebang for all scripts and making them comform with shellcheck. archiso/initcpio/{hooks,script}/*: Setting ash shebang for all scripts and making them comform with shellcheck (for dash, as shellcheck has no ash specific ruleset). Essentially the ash based scripts should be POSIX compliant as much as possible to have an easier time writing, debugging and maintaining them. Ensuring that variables are not treated as options and introducing variable quoting. .gitlab-ci.yml: Integrating shellcheck for initcpio scripts. Closes #32 --- install/archiso_pxe_common | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) (limited to 'install/archiso_pxe_common') diff --git a/install/archiso_pxe_common b/install/archiso_pxe_common index eec9a7e..da5f6b6 100644 --- a/install/archiso_pxe_common +++ b/install/archiso_pxe_common @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash build() { add_checked_modules -f "(irda|phy|wimax|wireless|ppp_|plip|pppoe)" "/drivers/net/" @@ -8,13 +8,13 @@ build() { add_binary /usr/lib/initcpio/ipconfig /bin/ipconfig # Add hosts support files+dns - add_symlink /usr/lib/libnss_files.so.2 $(readlink /usr/lib/libnss_files.so.2) - add_binary $(readlink -f /usr/lib/libnss_files.so.2) - add_symlink /usr/lib/libnss_dns.so.2 $(readlink /usr/lib/libnss_dns.so.2) - add_binary $(readlink -f /usr/lib/libnss_dns.so.2) + add_symlink /usr/lib/libnss_files.so.2 "$(readlink /usr/lib/libnss_files.so.2)" + add_binary "$(readlink -f /usr/lib/libnss_files.so.2)" + add_symlink /usr/lib/libnss_dns.so.2 "$(readlink /usr/lib/libnss_dns.so.2)" + add_binary "$(readlink -f /usr/lib/libnss_dns.so.2)" add_dir /etc - echo "hosts: files dns" > $BUILDROOT/etc/nsswitch.conf + echo "hosts: files dns" > "$BUILDROOT/etc/nsswitch.conf" } help() { @@ -22,5 +22,3 @@ cat<