From d45e77738bda2d17b10f87d05167a12fa5be8d63 Mon Sep 17 00:00:00 2001 From: Levente Polyak Date: Thu, 12 Jan 2023 21:33:00 +0100 Subject: commitpkg: properly cleanup commit msg file on abort Use the workdir location which gets cleaned up automatically. Previously this was leaking tmpfiles if the commitpkg command got aborted after file creation. Signed-off-by: Levente Polyak --- src/commitpkg.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/commitpkg.in b/src/commitpkg.in index 235d12b..2f0ea1f 100644 --- a/src/commitpkg.in +++ b/src/commitpkg.in @@ -132,7 +132,8 @@ if [[ -n $(svn status -q) ]]; then svn commit -q -m "${msgtemplate}: ${1}" || die stat_done else - msgfile="$(mktemp)" + [[ -z ${WORKDIR:-} ]] && setup_workdir + msgfile=$(mktemp --tmpdir="${WORKDIR}" commitpkg.XXXXXXXXXX) echo "$msgtemplate" > "$msgfile" if [[ -n $SVN_EDITOR ]]; then $SVN_EDITOR "$msgfile" -- cgit v1.2.3-54-g00ecf