From e2032db4e74c66d3f8bcba97497ccb5fff88df4b Mon Sep 17 00:00:00 2001 From: David Runge Date: Sat, 11 Jul 2020 18:13:20 +0200 Subject: Adding linting for initcpio scripts archiso/initcpio/install/*: Setting bash shebang for all scripts and making them comform with shellcheck. archiso/initcpio/{hooks,script}/*: Setting ash shebang for all scripts and making them comform with shellcheck (for dash, as shellcheck has no ash specific ruleset). Essentially the ash based scripts should be POSIX compliant as much as possible to have an easier time writing, debugging and maintaining them. Ensuring that variables are not treated as options and introducing variable quoting. .gitlab-ci.yml: Integrating shellcheck for initcpio scripts. Closes #32 --- .gitlab-ci.yml | 4 ++++ 1 file changed, 4 insertions(+) (limited to '.gitlab-ci.yml') diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index ab2f51e..74ecdd3 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -15,3 +15,7 @@ lint: configs/releng/airootfs/root/.automated_script.sh configs/releng/airootfs/usr/local/bin/choose-mirror scripts/run_archiso.sh + archiso/initcpio/install/* + - shellcheck -s dash + archiso/initcpio/hooks/* + archiso/initcpio/script/* -- cgit v1.2.3-54-g00ecf