From 32f268377ca8c224e8c6e942622a8bd1c5fb4bd7 Mon Sep 17 00:00:00 2001 From: 长柳 <110147328+changliuxy@users.noreply.github.com> Date: Mon, 1 Aug 2022 21:40:26 +0800 Subject: Update pull_request_template.md:11 ~20 -> twenty (#1398) I don't think this is a good way of writting like 'If the PR is larger than ~20 lines', it looks weird --- docs/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'docs/pull_request_template.md') diff --git a/docs/pull_request_template.md b/docs/pull_request_template.md index 5e6daf51..26b27ecc 100644 --- a/docs/pull_request_template.md +++ b/docs/pull_request_template.md @@ -8,7 +8,7 @@ Any patch work to existing versions will have to create a new branch against the # Describe your PR If the changes has been discussed in an Issue, please tag it so that we can backtrace from the issue later on.
-If the PR is larger than ~20 lines, please describe it here unless described in an issue. +If the PR is larger than twenty lines, please describe it here unless described in an issue. # Testing -- cgit v1.2.3-70-g09d2 From 4ab250d42741d914b162ca491b1f57fa25341d91 Mon Sep 17 00:00:00 2001 From: Anton Hvornum Date: Mon, 1 Aug 2022 16:24:02 +0200 Subject: Update the PR template Since most of the guidelines are in the contribution guidelines anyway, we'll keep the PR template to a minimum. --- docs/pull_request_template.md | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) (limited to 'docs/pull_request_template.md') diff --git a/docs/pull_request_template.md b/docs/pull_request_template.md index 26b27ecc..2332596a 100644 --- a/docs/pull_request_template.md +++ b/docs/pull_request_template.md @@ -1,15 +1,12 @@ -🚨 PR Guidelines: +- This fixes issue(s): -# New features *(v2.2.0)* +## PR Description: -All future work towards *`v2.2.0`* is done against `master` now.
-Any patch work to existing versions will have to create a new branch against the tagged versions. + -# Describe your PR - -If the changes has been discussed in an Issue, please tag it so that we can backtrace from the issue later on.
-If the PR is larger than twenty lines, please describe it here unless described in an issue. - -# Testing - -Any new feature or stability improvement should be tested if possible. Please follow the test instructions at the bottom of the README or use the ISO built on each PR. +## Tests and Checks +- [ ] I have tested the code!
+ -- cgit v1.2.3-70-g09d2 From f0111c179e35d0c905f67d46d0cf8b386ed768ac Mon Sep 17 00:00:00 2001 From: Anton Hvornum Date: Fri, 12 Aug 2022 15:04:16 +0200 Subject: Github doesn't seam to trigger on "fixes" but "fix" --- docs/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'docs/pull_request_template.md') diff --git a/docs/pull_request_template.md b/docs/pull_request_template.md index 2332596a..731bed8f 100644 --- a/docs/pull_request_template.md +++ b/docs/pull_request_template.md @@ -1,4 +1,4 @@ -- This fixes issue(s): +- This fix issue: ## PR Description: -- cgit v1.2.3-70-g09d2