Send patches - preferably formatted by git format-patch - to patches at archlinux32 dot org.
summaryrefslogtreecommitdiff
path: root/archinstall
AgeCommit message (Collapse)Author
2021-09-20Fix Bug: Cannot get partuuid from loop deviceHugo Ankarloo
File: lib/disk.py When installing on a loopback device (a.k.a loop device), function Filesystem.partuuid_to_index() crashes with a JSON parsing error. REASON 1) For loop devices, the property BlockDevice.device returns the actual image file (back-file) of the loop device instead of the /dev/X device. 2) Function Filesystem.partuuid_to_index() executes `lsblk --json` against BlockDevice.device . 3) `lsblk` fails and prints the error "not a block device" to stderr. This causes the output to not be valid JSON. 4) Code crashes when JSON parser tries to parse the output. SOLUTION - Make sure property BlockDevice.device only returns a valid block device. - Create new function BlockDevice.device_or_backfile that mimics the present behaviour of BlockDevice.device. - Use BlockDevice.device_or_backfile in function BlockDevice.__repr__(). SOLUTION REASONING I can only see one reason behind BlockDevice.device returning the back-file of a loop device, and that is to show the back-file to the user (instead of /dev/X) when printing the string representation of a BlockDevice. All other parts of the code can use the /dev/X file just fine. And IMO it makes more sense that a property named `device` only returns devices, and not normal files.
2021-09-20Fix Bug: Set filesystem crashes if no partitionsHugo Ankarloo
File: lib/user_interaction.py When function manage_new_and_existing_partitions() is used, and no partitions are configured, and 'Set desired filesystem for a partition' is selected, the installer crashes.
2021-09-20Fix Bug: config b0rked by Suggest partition layoutHugo Ankarloo
File: lib/user_interaction.py When function manage_new_and_existing_partitions() is used, and 'Suggest partition layout' is selected, the partition info is not correctly stored in the config. Instead of: {"partitions": [{...}, {...}]} You get: {"partitions": {"partitions": [{...}, {...}], "wipe":True}}
2021-09-20Fix Bug: Timezone is ignored, always same as hostHugo Ankarloo
Bug affects normal interactive usage (example/guided.py). The timezone configured in the installer is not the timezone that ends up in the new installed system. Instead, the timezone used in the host system (from where the installer is run) is the one that finally ends up being used. Reason: systemd-nspawn by default copies the host timezone into the target. And systemd-nspawn is run when keyboard-layout is changed (which is done after changing the timezone). Solution: Add option `--timezone=off` to systemd-nspawn, which hinders affecting the timezone in the target.
2021-09-06Merge pull request #623 from conqp/clean_hardware_importsAnton Hvornum
Remove unused import of json
2021-09-06Merge pull request #626 from conqp/refactor_meminfoAnton Hvornum
Refactor meminfo() to allow direct key access
2021-09-06Merge pull request #625 from conqp/fix_tab_indentationAnton Hvornum
Fix indentation with tabs instead of spaces
2021-09-06Fix indentation with tabs instead of spacesRichard Neumann
2021-09-06Refactor meminfo() to allow direct key accessRichard Neumann
2021-09-06Remove unused import of jsonRichard Neumann
2021-09-06Merged in masterAnton Hvornum
2021-09-06Merged in master.Anton Hvornum
2021-09-06Refactor cpu_model() to use cpuinfo()Richard Neumann
2021-09-06Refactor cpu_vendor() to use cpuinfo()Richard Neumann
2021-09-06Merge branch 'master' into native_cpu_detectionAnton Hvornum
2021-09-06Merge pull request #610 from luckspt/patch-2Anton Hvornum
Typo
2021-09-06Merge pull request #605 from CYPT71/patch-1Anton Hvornum
Update hardware.py
2021-09-06Added exception handling to check_outputAnton Hvornum
I tweaked the optimized return of check_output. Worth mentioning that `check_output()` will raise an exception `subprocess.CalledProcessError: Command 'lscpu | grep AMD' returned non-zero exit status 1.`.
2021-09-06No need for try/catch any longer.Anton Hvornum
The old behavior of SysCommand was that exit codes raised an exception, which needed to be handled by each individual caller. We now utilize `.exit_code` instead to manually detect faulty commands and raise exceptions where needed.
2021-09-06Merge branch 'master' into masterAnton Hvornum
2021-09-06Merge pull request #600 from monosans/comprehensionAnton Hvornum
Replace for loops with comprehensions
2021-09-06Corrected some minor modifications mentioned in #595 as well as merged in ↵Anton Hvornum
latest changes from master. For future PR's do create a patch-branch for upstream patches to avoid changes to your local repo.
2021-09-04Merge branch 'master' of github.com:archlinux/archinstall into ↵Anton Hvornum
torxed-rework-partitioning
2021-09-04Fixed edge case where size of disks could be exactly 40GB and a /home would ↵Anton Hvornum
never be created on single devices.
2021-09-04Added a PARTUUID -> parted index, this in order to properly set the boot ↵Anton Hvornum
flag on the correct partition. Perhaps there's a smarter way. I suspect parted can operate on a given partition ID, but haven't found the docs for it yet.
2021-09-04Simplified lambda and made it filter out non relevant disks for the ↵Anton Hvornum
selection process.
2021-09-04Fixed filtering if largest disk selectionAnton Hvornum
2021-08-20Remove excess newlineRichard Neumann
2021-08-20Rewrite CPU vendor detection functionsRichard Neumann
Use cpuinfo() function rather than a subprocess.
2021-08-20Add cpuinfo()Richard Neumann
2021-08-18Reworking logic that selects / and /home for multi-disk configurations. Also ↵Anton Hvornum
added some more debugging
2021-08-17Fixed a prompt error in one of the parted calls. Also started on a more ↵Anton Hvornum
reliable size-conversion that isn't limited to Gigabytes in free_space().
2021-07-28TypoLucas Pinto
Fix a tiny typo
2021-07-22Update hardware.pyCYPT71
Rewrite some function if condition is True then return true else return false, transform in return condition directly Also I don't understand why we need a try/except at line 151 and why we not write return condition ??
2021-07-19Mention GNOME and KDE's soft dependency on NetworkManager in the installj-james
2021-07-18changed dry_run to dry-runYash Tripathi
2021-07-18fix for #602, running mklabel before formattingYash Tripathi
2021-07-18created load_config() to load configurationYash Tripathi
2021-07-16Replace for loops with comprehensionsmonosans
2021-07-07Fix encryption + grub both in UEFI and BIOS systems.Hamad Al Marri
We need to have two partitions in BIOS one for boot (grub) and the other for root (/). The format of the boot partition is ext2 (so it is added). If disk is chosen to be encrypted, `then /etc/default/grub` is edited as the followings: https://wiki.archlinux.org/title/Dm-crypt/Encrypting_an_entire_system#Configuring_GRUB_2 Issue: https://github.com/archlinux/archinstall/issues/586 This work is done while working on CachyOS which is Arch based and it is using customized archinstaller. To test these changes you can try CachyOS installer which supports encrypted disk with grub (https://wiki.cachyos.org/). Hamad
2021-07-04Removed debuggingAnton Hvornum
2021-07-04Added a filesystem check when marking for formatting, this should ensure ↵Anton Hvornum
that encrypted volumes get a proper filesystem without having to go through an extra step of selecting filesystem.
2021-07-03Added options to mark/unmark partitions for formatting (useful when re-using ↵Anton Hvornum
partitions, and fine tune which data to save and which to wipe). Setting a desired filesystem for a partition (both new ones and the ones being re-used).
2021-07-03Saving partitioning layout in a layout file (JSON format)Anton Hvornum
2021-07-03Missing .format() on 'use entire disk' stepAnton Hvornum
2021-06-15Added more detail to BlockDevice.__repr__Anton Hvornum
2021-06-15Added fs-type and formatting on encrypted partitions that haven't been given ↵Anton Hvornum
a fs-type prior when re-using partitions.
2021-06-14Change of variableAnton Hvornum
2021-06-14moved valid_parted_position to disk. And made it handle float numbers.Anton Hvornum
2021-06-14Since all fs-type's appear to be lower-case in 'man parted', we'll check ↵Anton Hvornum
against a lowered list in general for supported fs-types.